Skip to content

Support showing description from text document #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from

Conversation

Vigilans
Copy link
Contributor

@Vigilans Vigilans commented Apr 26, 2019

Solves #286

Relies on leetcode-tools/leetcode-cli#13

Demonstration:
demo2

@Vigilans Vigilans requested a review from jdneo April 26, 2019 16:19
@jdneo
Copy link
Member

jdneo commented Apr 27, 2019

@Vigilans First of all, thank you for the enthusiasm you give.

One thing I have to mentions is that, please do not try to solve multiple issues in one PR. This very hard for tracking the issues.

Could you please revert this PR to make it only solve #287 first. And please let me know what I can do to help you achieve that.

Thanks.

@Vigilans
Copy link
Contributor Author

Vigilans commented Apr 27, 2019

#287 has already been solved in #289 4 days ago and is waiting for the leetcode-cli dependency update.

This three issues all point to the same thing (comment in #287 is duplicate of #286), splitting this PR will result in a PR of 90% content and a PR with 10% content.

@Vigilans
Copy link
Contributor Author

Could you please revert this PR to make it only solve #287 first. And please let me know what I can do to help you achieve that.

This PR doesn't solve #287

@jdneo
Copy link
Member

jdneo commented Apr 27, 2019

I see. I've added comments in #289.

But still, I would like to request you to split the PR even it's 10% + 90%. Thank you for your understanding.

@Vigilans Vigilans changed the title Support showing description and solution from text document Support showing description from text document Apr 27, 2019
@Vigilans Vigilans closed this May 9, 2019
@Vigilans Vigilans deleted the vigilans/codelens branch May 9, 2019 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants